Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- added typeaheadOnBlur event #1639

Merged
merged 5 commits into from
Feb 28, 2017
Merged

- added typeaheadOnBlur event #1639

merged 5 commits into from
Feb 28, 2017

Conversation

imribarr-compit
Copy link
Contributor

  • added documentation for typeaheadOnBlur
  • removed tab event key since blur event handles it
  • added getter to _active item

@imribarr-compit
- added typeaheadOnBlur event
d098055 
- added documentation for typeaheadOnBlur
- removed tab event key since blur event handles it
- added getter to _active item
@SergeyKuryatnick
Copy link
Contributor

closes #1636

@codecov-io
Copy link

codecov-io commented Feb 13, 2017 •
edited
Loading

Codecov Report

Merging #1639 into development will increase coverage by 0.13%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1639      +/-   ##
===============================================
+ Coverage        84.84%   84.98%   +0.13%     
===============================================
  Files               85       85              
  Lines             2323     2324       +1     
  Branches           299      298       -1     
===============================================
+ Hits              1971     1975       +4     
+ Misses             252      249       -3     
  Partials           100      100
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 76.79% <100%> (+1.52%) ✅
src/typeahead/typeahead-container.component.ts 74.66% <100%> (+0.69%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb4e5...75aedb1. Read the comment docs.

valorkin
valorkin requested changes Feb 15, 2017
View reviewed changes
src/typeahead/typeahead.directive.ts

// if tab default browser behavior will select next input field, and
// therefore we should close the items list
if (e.keyCode === 9) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@valorkin
Copy link
Member

@imribarr-compit looks good to me, but small change needed

@valorkin
Copy link
Member

BTW if you can add small test for this, it would be just awesome

@imribarr-compit
Copy link
Contributor Author

@valorkin I've added a test for this. If you could just reply on my change request that would be great.

Thanks.

@valorkin
Copy link
Member

Looks good to me!

@valorkin valorkin merged commit 62eb22a into valor-software:development Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees
No one assigned
Labels
comp(typeahead) needs review needs: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imribarr-compit @SergeyKuryatnick @codecov-io @valorkin